ast: fix Restore for INL_HASH_JOIN / INL_MERGE_JOIN hints #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-srebot
approved these changes
Nov 11, 2020
|
Don't merge this PR until TiDB PR is ready to be merged. |
|
cherry pick to release-4.0 failed |
eurekaka
added a commit
to eurekaka/parser
that referenced
this pull request
Nov 16, 2020
kennytm
pushed a commit
that referenced
this pull request
Nov 16, 2020
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently, hint
INL_HASH_JOIN(t1,t2)would be restored asINL_HASH_JOIN(), which would causeexplain format = 'hint'or baseline capture broken.What is changed and how it works?
Restore table parameters for these 2 kinds of hints.
Check List
Tests
Code changes
N/A
Side effects
N/A
Related changes